carbon-language / carbon-lang

Carbon Language's main repository: documents, design, implementation, and related tools. (NOTE: Carbon Language is experimental; see README)
https://github.com/carbon-language/carbon-lang/blob/trunk/README.md
Other
32.3k stars 1.48k forks source link

Fix drop_back call in scope_stack #4099

Closed jonmeow closed 2 days ago

jonmeow commented 3 days ago

I found this through inspection, looking at an array stack data type. Tests pass either way, not sure what a good test would be for regressions (tests do fail if the size doesn't match, but either approach gets an appropriate size). But this is followed by truncate(remaining_compile_time_bindings), so it seems like drop_back is a better match than drop_front.