This adds fields to EntityWithParamsBase to reflect the intention with extern library design. I'm renaming decl_id because it shouldn't be expected to be assigned anymore. import_ref.cpp I'm deliberately keeping on first_owning_decl_id (which will break when importing extern library declarations). Most other cases are for diagnostics, and I'm using latest_decl_id to try and get the closest declaration to the error. Note I'm partly splitting out this PR to show the test effect, which apparently we don't test related cases.
This adds fields to
EntityWithParamsBaseto reflect the intention withextern librarydesign. I'm renamingdecl_idbecause it shouldn't be expected to be assigned anymore. import_ref.cpp I'm deliberately keeping onfirst_owning_decl_id(which will break when importingextern librarydeclarations). Most other cases are for diagnostics, and I'm usinglatest_decl_idto try and get the closest declaration to the error. Note I'm partly splitting out this PR to show the test effect, which apparently we don't test related cases.