Re-evaluate optional features when optimizing compile time

carbon-language / carbon-lang

Carbon Language's main repository: documents, design, implementation, and related tools. (NOTE: Carbon Language is experimental; see README)

http://docs.carbon-lang.dev/

Other

32.35k stars 1.48k forks source link

Re-evaluate optional features when optimizing compile time #4231

Open dwblaikie opened 3 months ago

dwblaikie commented 3 months ago

There are a few features that we've enabled by default that are nice to have - but at some point, especially when promoting carbon to users more heavily, we may want to ensure these features aren't costing too much, especially in compile time, and harming users first impressions.

So far the list is:

parse tree validation (an internal consistency check)
debug info (enabled by default, unlike other compilers (gcc, clang, etc) that disable this by default, presumably because it's too expensive to enable by default - carbon plans to have relatively light debug info compared to C++ so maybe it can get away with paying this cost by default)

jonmeow commented 2 months ago

parse tree validation (an internal consistency check)

Just to be sure, there's some minimal validation, but #4174 turned off the really expensive parts (in opt mode, anyways).

zygoloid commented 2 months ago

CARBON_CHECK -- while we want some of those to remain, it'd be worth doing a performance comparison with all of the checks disabled to get a measure of how much we're paying. If it's a lot, we should carefully pick specific instances that we might want to turn into CARBON_DCHECK.
CARBON_VLOG -- similarly, disabling all of these would give us an idea of whether we're leaving performance on the table here, and maybe we can reduce that cost.

muhd360 commented 1 month ago

@zygoloid hi, are there any easy first issues i can work on to get my hands dirty in the repo? Cant see any on the issues page.