tests Tokenized Carbon Credits

carbonable-labs / carbon-protocol-v3

Apache License 2.0

3 stars 9 forks source link

tests Tokenized Carbon Credits #37

Closed julienbrs closed 3 weeks ago

julienbrs commented 3 weeks ago

closes #25

Functions tested

in test_carbon_handler.cairo

compute_carbon_vintage_distribution
get_cc_vintages

Additional information:

Should we check the rightness of the share argument in the compute method? Or is it an assumed counstraints (between 0 and 100)?
INVALID_STARTING_YEAR might be raised in compute_carbon_vintage_distribution. It hasn't been tested, because mismatch_length error is already detected in the setter (set_absorptions).

cloudvenger commented 3 weeks ago

Should we check the rightness of the share argument in the compute method? Or is it an assumed counstraints (between 0 and 100)?

As the Share is compute only in the Minter and not pass as parameters (after setup the access control), we could assumed the constrain

cloudvenger commented 3 weeks ago

INVALID_STARTING_YEAR might be raised in compute_carbon_vintage_distribution. It hasn't been tested, because mismatch_length error is already detected in the setter (set_absorptions).

Sorry, I dont understand your point