[FIX]Ignore cache requests & no track incognito host Issue #15

carbonalyser / Carbonalyser

The add-on "Carbonalyser" allows to visualize the electricity consumption and greenhouse gases (GHG) emissions that your Internet browsing leads to.

https://theshiftproject.org/en/carbonalyser-browser-extension/

MIT License

148 stars 37 forks source link

[FIX]Ignore cache requests & no track incognito host Issue #15 #34

Open cguignol opened 4 years ago

cguignol commented 4 years ago

Merge of Jolg42's work with recent evolution for Chrome + add testing.

Some of his work list adding "const" for the declaration of functions has not been added because of problems not solved about testability of the code.

cguignol commented 4 years ago

Thanks for the code review @Jolg42 , code smells better like that. I played automated test to verify that everything is OK.

supertanuki commented 4 years ago

@cguignol why this PR is closed?

Jolg42 commented 4 years ago

Because it was "Merged" somehow 🤷‍♂️ https://github.com/cguignol/Carbonalyser/blob/master/script.js

supertanuki commented 4 years ago

@Jolg42 it's the forked repo

Jolg42 commented 4 years ago

Oh yes indeed 😅

cguignol commented 4 years ago

Smells like a mistake from me, I apologize and reopen the Pull Request ;)