carbonalyser / Carbonalyser

The add-on "Carbonalyser" allows to visualize the electricity consumption and greenhouse gases (GHG) emissions that your Internet browsing leads to.
https://theshiftproject.org/en/carbonalyser-browser-extension/
MIT License
148 stars 37 forks source link

Decimal place and separator #5

Open jhlochner opened 5 years ago

jhlochner commented 5 years ago

Hi, thanks for this nice plugin. A small notation issue, which made much irritation on my side: In the overview how much energy/co2 I produced, in my case, its written: 1.547 kWh 3.636 km of car drive

As a german I am used to have , as decimal seperator and . as thousands seperator. Therefore my first thought was: What the hell, nearly 4 thousand km of car drive???

My suggestion for this issue is:

Thank you for the time you put into this project! twain

supertanuki commented 5 years ago

Thank you for your feedback. Interesting. But we will need to manage values under 0.1 For example 0.001 can not be rounded to 0.1. I will give a look.

If you want to contribute to the german version, you can create a de/messages.json based on this file https://github.com/supertanuki/Carbonalyser/blob/master/_locales/en/messages.json

jhlochner commented 5 years ago

I would love to contribute more but sadly I have no time right now. I am curious, where do you need values with a precision of 0.001? I would doubt that it is possible to estimate the energy consumption with such a high precision. In the end the standard errors should be relative high, right?