Updated Dockerfile for pip install - Githubissues

carbonblack / cbc-syslog

Syslog Connector for the Carbon Black Cloud

MIT License

28 stars 10 forks source link

Updated Dockerfile for pip install #46

Closed kebringer-cb closed 4 years ago

kebringer-cb commented 4 years ago

Changed Dockerfile to install using pip and removed all RPM build actions. Updated README with info to use Docker.

Pull request checklist

Please check if your PR fulfills the following requirements:

[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Tests have been added that prove the fix is effective or that the feature works. Manually tested on Centos7.
[ ] New and existing tests pass locally with the changes.
[ ] Code follows the style guidelines of this project (PEP8, clean code).
[ ] Linter has passed locally and any fixes were made for failures.
[ ] A self-review of the code has been done.

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes (not tied to bugs/features)
[ ] Other (please describe):

What is the ticket or issue number?

Ticket Number: https://jira.carbonblack.local/browse/CBAPI-1879
Issue Number: N/A

Pull Request Description

Updated the Dockerfile to install using pip to align with cross platform changes done previously. Replaces creating an RPM.

Does this introduce a breaking change?

[ ] Yes
[x] No

How Has This Been Tested?

Manual testing on Centos7 machine.

Other information: