carbonblack / intellij-rpmspec

An IntelliJ plugin for RPM SPEC file support
Apache License 2.0
11 stars 4 forks source link

Icon not rendered correctly #3

Closed thaJeztah closed 4 years ago

thaJeztah commented 4 years ago

Both in Goland 2019.3.1, and IntelliJ IDEA 2020.1 (Community Edition), the icon does not render correctly; the background of the icon is scaled, but filled "red" instead of transparent. (Possibly the Intellij platform doesn't handle the gradients correctly?)

I'm running on macOS Mojave (10.4.6) on a retina screen. Here's some screenshots:

Screenshot 2020-04-10 at 09 20 37 Screenshot 2020-04-10 at 09 20 43 Screenshot 2020-04-10 at 09 31 31

The problem reproduced both in "dark" (darkula) and light mode

And info of the versions I'm running;

Screenshot 2020-04-10 at 09 22 26 Screenshot 2020-04-10 at 09 35 07

I tried looking at the docs but nothing really stood out (other than there's no _dark variants of the icon); https://www.jetbrains.org/intellij/sdk/docs/reference_guide/work_with_icons_and_images.html

The naming notation used for PNG icons (see below) is still relevant. However, the @2x version of an SVG icon should still provide the same base size. The icon graphics of such an icon can be expressed in more details via double precision. If the icon graphics are simple enough so that it renders perfectly in every scale, then the @2x version can be omitted.

thaJeztah commented 4 years ago

@tlusk ptal πŸ€—

tlusk commented 4 years ago

πŸ€” That is strange, I'm not seeing that in IntelliJ 2020.1 ultimate edition under OpenSUSE and CentOS.

icons

I'll see what I can do to try to reproduce it but if I can't I'm not sure what I'd do to fix it. I'll take a look soon.

tlusk commented 4 years ago

Very quick update, I was able to reproduce it already by changing the OpenSUSE scaling to 200% πŸ˜„

scale

I'll see what I can do!

tlusk commented 4 years ago

@thaJeztah found the issue, it's resolved in 1.1.1 which has been uploaded to the plugin repo and will be approved within the next 48 hours.

thaJeztah commented 4 years ago

Oh, wow, thanks for taking a look, and happy to see you were able to find the problem! I'll look out for the 1.1.1 patch release πŸŽ‰ πŸ₯³

thaJeztah commented 4 years ago

The updates arrived, and I can confirm the issue is fixed. Thanks again!