search

carboncredits / x4c

MIT License
2 stars 0 forks source link

internal_transfer and external_transfer events #21

Open sadiqj opened 2 years ago

sadiqj commented 2 years ago

We need a similar param/event mechanism for internal_transfer and external_transfer so we can eventually include some context and pricing information for transactions that happen off-chain.

@differentialderek as discussed earlier

dhsorens commented 2 years ago

After discussion with @sadiqj, since events are coming in Kathmandu, we will wait briefly on this

mdales commented 2 years ago

@sadiqj can you provide some context to this, or can we close this as a duplicate of #42?

sadiqj commented 2 years ago

So #42 only covers events on retirement, the intention here is to also include events for external and internal transfers from the custodian.

mdales commented 2 years ago

Chatting to @patricoferris, we'll need internal mint and internal transfer emits for the MVP, as he is expected to retire the oldest tokens first, and by adding emits on internal_mint is the only way to get a sense of history for which tokens at the oldest.