search

carbonfive / funnel

little ci server for git hygiene
https://funnel-c5.herokuapp.com/
7 stars 1 forks source link

Bug: Appears to have trouble with forked repos #29

Open hannahhoward opened 6 years ago

hannahhoward commented 6 years ago

Steps to reproduce:

  1. Install funnel on a repo
  2. Fork that repo to another person/organization
  3. Make a properly rebased and squashed branch on the forked repo
  4. Submit a PR from the forked repo to the original

Pretty sure Funnel will fail

See current status on #28 - I believe it's rebased and squashed.

outofambit commented 6 years ago

Yes this true, and something that should be fixed. The cause is that a Scent only captures the user and repo name of the pushed to branch. This works fine for branches in the same repo, but not those in different ones.

I think the solution to this is to modify https://github.com/carbonfive/funnel/blob/5cc5c05b3ff186538f2a9de959502c5027d87bf5/lib/funnel/scent.ex#L46 to capture this extra information from the GitHub webhook and then utilize it in https://github.com/carbonfive/funnel/blob/master/lib/funnel/investigator/strategy.ex