search

carbynestack / castor

Carbyne Stack tuple store for secure multiparty computation
https://carbynestack.io
Apache License 2.0
7 stars 4 forks source link

Reservation handling #29

Closed sbckr closed 2 years ago

sbckr commented 2 years ago

covers #10

codecov[bot] commented 2 years ago

Codecov Report

Merging #29 (fc64067) into master (a44a7dd) will increase coverage by 0.40%. The diff coverage is 94.20%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #29      +/-   ##
============================================
+ Coverage     85.47%   85.88%   +0.40%     
- Complexity      336      349      +13     
============================================
  Files            61       61              
  Lines          1212     1275      +63     
  Branches         80       81       +1     
============================================
+ Hits           1036     1095      +59     
- Misses          142      144       +2     
- Partials         34       36       +2
Impacted Files Coverage Δ
...e/persistence/cache/UnlockReservationSupplier.java 100.00% <ø> (ø)
...castor/service/rest/ReservationRestController.java 25.00% <0.00%> (ø)
...ack/castor/service/rest/TupleChunksController.java 25.00% <0.00%> (ø)
...service/download/DefaultTuplesDownloadService.java 95.23% <90.90%> (+4.09%) :arrow_up:
...e/persistence/cache/ReservationCachingService.java 95.76% <94.25%> (-4.24%) :arrow_down:
...ragmentstore/TupleChunkFragmentStorageService.java 95.16% <95.16%> (ø)
...stence/fragmentstore/TupleChunkFragmentEntity.java 95.23% <95.23%> (ø)
...castor/service/config/CastorServiceProperties.java 91.66% <100.00%> (+0.75%) :arrow_up:
...tack/castor/service/download/TelemetryService.java 100.00% <100.00%> (ø)
...e/persistence/cache/CreateReservationSupplier.java 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a44a7dd...fc64067. Read the comment docs.

sbckr commented 2 years ago

@grafjo @kindlich Finally, the handling of reservations and tuple consumption have been revised. I would really appreciate if you could take a look and test if the new implementation fixes the described issue.

I am happy to discuss the changes that have been made.

strieflin commented 2 years ago

Cannot merge this @sbckr as not all of your commits are signed.

sbckr commented 2 years ago

Cannot merge this @sbckr as not all of your commits are signed.

@strieflin Thank you for your review. All commits are now signed accordingly