search

card-io / card.io-Android-SDK

card.io provides fast, easy credit card scanning in mobile apps
Other
1.99k stars 535 forks source link

Focus is not working well for Amazon Fire Phone #24

Open fcduarte opened 10 years ago

fcduarte commented 10 years ago

Hi guys,

first of all thanks for the great lib. Did you guys have time to play with it on Fire Phone? One thing is really strange, about 80% of the times I start the card.io reader the focus is on far objects instead of being on the card I'm trying to read. And then since the card is blurred the reader doesn't work.

I don't know much about photography but some things could be done with Android's camera intent like setting auto-focus or setting the focus to macro. Are you guys doing it? Maybe on a new version it would be good to have the same tap-to-focus behavior as stock Camera app have.

I'm glad to provide more info if needed.

Thanks,

braebot commented 10 years ago

It does look like card.io attempts to autofocus, which could be causing problems on the Amazon Fire.

We haven't had a chance to test with this phone. Each phone/camera behaves slightly different, so we'll have to analyze what's going here. Are you using the latest version of card.io?

fcduarte commented 10 years ago

Yes, I'm using the latest version. Well I could also request for a feature: when tapping on the screen card.io could try to re-focus, the same way as native Camera app works, what do you think?

braebot commented 10 years ago

I'm not sure how easy that will be, considering that we're already attempting to autofocus. I wouldn't think you can have both autofocus, and manual focus at the same time.

fcduarte commented 10 years ago

I see.. So since the card will always be close to the camera don't you think it makes sense to change focus mode to macro instead of auto-focus? That way you could also have the tap on the screen for focus.

Anyway it's just suggestions to be tested.

braebot commented 10 years ago

I agree in principle. My iOS colleagues tell me that in iOS-land, a user can trigger a refocus at any time by tapping the screen, but that it's still a manually-triggered autofocus, rather than specifying where on the screen to focus.

We'll discuss with the original developers about macro vs. auto-focus in Android-land. There may have been a method to their madness, and is definitely worth another look. :dancers:

fcduarte commented 10 years ago

Awesome, thanks! BTW on Android-land users are getting used to this same tap-to-focus feature because of KitKat, when it introduced the new Camera app.