search

card-io / card.io-Android-source

The open-source code for the card.io-Android-SDK: provides fast, easy credit card scanning in mobile apps
Other
569 stars 376 forks source link

Custom Manual Entry Activity #132

Open kylannjohnson opened 7 years ago

kylannjohnson commented 7 years ago

General information

Issue description

My question is more for an enhancement. Have you ever considered letting the caller to CardIOActivity specify their own Activity for manual entry? The caller could simply provide an Intent to be used to launch the activity.

This feature would be nice for users who want to significantly customize the manual entry screen.

Thanks!

lkorth commented 7 years ago

You should be able to accomplish exactly this by disabling manual entry and filling in your manual entry screen with any data that comes back from the scan. The only difference would be if the user doesn't want to scan their card, they would have to press back or cancel instead of the keyboard icon.

kylannjohnson commented 7 years ago

That was the original implementation I went with, but, as you suggest, the keyboard button is no longer usable. IMO, this could be a bad user experience as the user would have to purposefully pick "manual entry" to launch the custom activity from the activity that launched card.io rather than selecting "manual" entry in the card.io screen.

Does the approach I said for providing an intent make sense? Can you think of another approach?

kylannjohnson commented 7 years ago

Just circling back. Any thoughts here @lkorth ?