fix: card.io-Android-source issue #60

card-io / card.io-dmz

The core image-processing and machine-learning code for card.io, which is shared between iOS and Android.

Other

141 stars 116 forks source link

fix: card.io-Android-source issue #60 #27

Closed m-schmoock closed 8 years ago

m-schmoock commented 8 years ago

https://github.com/card-io/card.io-Android-source/issues/60

Using newer Android NDK versions (11+) to compile DMZ result in errors:

Eigen: inline assembler that is generated by using POSIX alloca function (artificially writing r13 stackpointer register is now forbidden)
Eigen: posix_memalign seems to be missing

I wrote pre-processor directives that bypass the issues on Android. We can remove them once the Android NDK team fixes it. Performance impact seems to be minimal.

josharian commented 8 years ago

Thanks! LGTM, but leaving for someone else to merge.

Have you reported this issue upstream to Eigen?

m-schmoock commented 8 years ago

No worries.

I have not reported it yet since I was unsure if this is Eigen or Android NDK related. I tend to the latter one as using POSIX alloca should also be possible on Android/ARM.

Also I have skipped to investigate the posix_memalign() in detail and just turned it off for Android.

Regards, Michael

braebot commented 8 years ago

Thanks for the PR! I tested this on quite a few cards, and agree that I don't notice any degradation of performance. Merging.