Support for Diners Club or CUP cards?

[wendymackinnonkeith]

Is there any plan to add support for scanning Diners Club or China Union Pay cards?

[romk1n]

@wendymackinnonkeith Diners Club was acquired by Discover in 2011, so it should be recognized as Discover card type. What type did you get when you tried scanning your card ?

[wendymackinnonkeith]

When I try to enter any Diners Club with card numbers starting with 3699 3059 3095 and 3899 they show up in a red coloured font and I cannot continue.

I get the same result when entering CUP card numbers starting with 6240 and 6288 - only the CUP card numbers starting with 6229 appear as a CUP card number

Thanks,

Wendy

On Mon, Jun 9, 2014 at 12:17 PM, romk1n notifications@github.com wrote:

@wendymackinnonkeith https://github.com/wendymackinnonkeith Diners Club was acquired by Discover in 2011, so it should be recognized as Discover card type. What type did you get when you tried scanning your card ?

— Reply to this email directly or view it on GitHub https://github.com/card-io/card.io-iOS-SDK/issues/51#issuecomment-45510033 .

[romk1n]

@wendymackinnonkeith i will pass this information to our development team and we will response with some more information as soon as we can! thanks!

[wendymackinnonkeith]

Awesome - thanks

On Mon, Jun 9, 2014 at 12:44 PM, romk1n notifications@github.com wrote:

@wendymackinnonkeith https://github.com/wendymackinnonkeith i will pass this information to our development team and we will response with some more information as soon as we can! thanks!

— Reply to this email directly or view it on GitHub https://github.com/card-io/card.io-iOS-SDK/issues/51#issuecomment-45513153 .

[dgoldman-pdx]

@wendymackinnonkeith thanks for bringing this up.

At the moment, our manual-entry screen accepts the same five credit card types as our camera scan screen -- Visa, MasterCard, American Express, Discover, and JCB.

Adding additional recognized card types to the scanning screen can be a bit tricky, and so before doing so we need to hear a significant level of interest from our third-party clients (such as yourself).

In the meantime, though, we could allow the manual-entry screen to accept any card number that passes the Luhn checksum test, without requiring the number's prefix to match one of our currently-supported card types. The returned CardIOCreditCardType would then be CardIOCreditCardTypeUnrecognized.

Would that change satisfy your present needs?

[wendymackinnonkeith]

Hi Dave

Let me circle back to my Dev team - the original request came from Discover to us - we (Digital Retail Apps) have a multi retailer in-aisle shop+pay app that launched in Dec 2013 (SelfPay) on the Apple App store - we have support for V MC AmEx Discover and PayPal as ways to pay and noticed that we couldn't add a Diners or some China Union Pay cards in app. We are currently live in Canada and are in discussions with retailers in US, UK and UAE. Our credit card option uses card.io to enter a new card - details are then sent from the consumer mobile device running our app to our payment gateway partner Digital River for vaulting. We were looking to be able to support all the Discover brand cards with you SDK.

Will write back shortly.

Wendy

On Tue, Jun 10, 2014 at 1:30 PM, Dave Goldman notifications@github.com wrote:

@wendymackinnonkeith https://github.com/wendymackinnonkeith thanks for bringing this up.

At the moment, our manual-entry screen accepts the same five credit card types as our camera scan screen -- Visa, MasterCard, American Express, Discover, and JCB.

Adding additional recognized card types to the scanning screen can be a bit tricky, and so before doing so we need to hear a significant level of interest from our third-party clients (such as yourself).

In the meantime, though, we could allow the manual-entry screen to accept any card number that passes the Luhn checksum http://en.wikipedia.org/wiki/Luhn_algorithm test, without requiring the number's prefix to match one of our currently-supported card types. The returned CardIOCreditCardType would then be CardIOCreditCardTypeUnrecognized.

Would that change satisfy your present needs?

— Reply to this email directly or view it on GitHub https://github.com/card-io/card.io-iOS-SDK/issues/51#issuecomment-45645633 .

[wendymackinnonkeith]

Hi Dave

That would be a big help for now. Thanks for your quick reply. Let us know if you add support for Diners and CUP card recognition at a later date.

Many Thanks,

Wendy

Wendy MacKinnon Keith CEO & Founder Digital Retail Apps 416 994 4771 twitter.com/digitalretail digitalretailapps.com

Sent from my iPhone

On Jun 10, 2014, at 1:30 PM, Dave Goldman notifications@github.com wrote:

@wendymackinnonkeith thanks for bringing this up.

At the moment, our manual-entry screen accepts the same five credit card types as our camera scan screen -- Visa, MasterCard, American Express, Discover, and JCB.

Adding additional recognized card types to the scanning screen can be a bit tricky, and so before doing so we need to hear a significant level of interest from our third-party clients (such as yourself).

In the meantime, though, we could allow the manual-entry screen to accept any card number that passes the Luhn checksum test, without requiring the number's prefix to match one of our currently-supported card types. The returned CardIOCreditCardType would then be CardIOCreditCardTypeUnrecognized.

Would that change satisfy your present needs?

— Reply to this email directly or view it on GitHub.

[dgoldman-pdx]

Wendy, in addition to the change I proposed to make manual-entry more forgiving, we went ahead and added the Diners Club and CUP prefixes to our card scanner, after all. :) Let us know if anything fails to perform correctly for you.

New version 3.8.0 available here.

[wendymackinnonkeith]

Great news! Many thanks for making the change.

Wendy

Wendy MacKinnon Keith CEO & Founder Digital Retail Apps 416 994 4771 twitter.com/digitalretail digitalretailapps.com

Sent from my iPhone

On Jun 11, 2014, at 6:14 PM, Dave Goldman notifications@github.com wrote:

Wendy, in addition to the change I proposed to make manual-entry more forgiving, we went ahead and added the Diners Club and CUP prefixes to our card scanner, after all. :) Let us know if anything fails to perform correctly for you.

New version 3.8.0 available here.

— Reply to this email directly or view it on GitHub.

[jpaas]

Thanks Dan! Is PayPal also maintaining the Cocoapod for this library? We are using the cocoapod but it hasn't been updated since 3.6.3.

[dgoldman-pdx]

@jpaas so far the CocoaPod is community-maintained. We are considering taking it over at some point in the future, but haven't made any decisions.

[jpaas]

I actually have push access for the cocoa pods repository, so I'll submit an update. Not sure if you're aware, but cocoapods are changing their publishing mechanism to have actual owners as part of a new publishing system called Trunk. As part of the migration to Trunk, they are having a sort of amnesty period where people can claim ownership over pods. This might be a good time for you take it over, by submitting an ownership claim. http://blog.cocoapods.org/Claim-Your-Pods/

[jpaas]

I've created and tested the new podspec, but it seems that cocoapods has cut over to the new trunk system and is no longer accepting pushes directly against the Specs repo. So someone needs to claim the pod. Dan, will you claim it, or would you like me to?

Here is the pod spec source, if you'd like to add it to the root of the CardIO repo..

Pod::Spec.new do |spec|
  spec.name             = 'CardIO'
  spec.version          = '3.8.0'
  spec.license          = { type: 'MIT', file: 'LICENSE.md' }
  spec.homepage         = 'https://www.card.io'
  spec.authors          = { 'CardIO' => 'support@paypal.com' }
  spec.summary          = 'Credit card scanning for mobile apps'

  spec.source           = { http: 'https://github.com/card-io/card.io-iOS-SDK/releases/download/v3.8.0/card.io_ios_sdk_3.8.0.zip', flatten: true }
  spec.platform         = :ios, '5.0'
  spec.requires_arc     = true
  spec.source_files     = 'CardIO/*.h'
  spec.preserve_path    = 'CardIO/*.a'
  spec.frameworks       = 'AVFoundation', 'AudioToolbox', 'CoreMedia', 'CoreVideo', 'MobileCoreServices', 'OpenGLES', 'QuartzCore', 'Security', 'UIKit'
  spec.libraries        = 'CardIO', 'c++'
  spec.xcconfig         = { 'LIBRARY_SEARCH_PATHS' => '"$(PODS_ROOT)/CardIO/CardIO"' }
end

[dgoldman-pdx]

Thanks, @jpaas. I guess it is indeed time for us to claim the pod. I'll pursue that...

[dgoldman-pdx]

Thanks for your help, @jpaas. I think we're all set now on CocoaPods.