search

card-io / card.io-iOS-source

The open-source code for the card.io-iOS-SDK: provides fast, easy credit card scanning in mobile apps
Other
686 stars 372 forks source link

Enable Bitcode #39

Closed bluk closed 9 years ago

bluk commented 9 years ago

This is preliminary work to enable Bitcode ( card-io/card.io-iOS-SDK#119 ). It "worked for me" with some initial testing on a real device using the sample app but would appreciate additional eyes. As mentioned in the issue, https://forums.developer.apple.com/thread/3971 seems to be the best source of documentation and mentions the "-fembed-bitcode" flag and GENERATE_MASTER_OBJECT_FILE issue.

I did not use DMZ_HAS_NEON_COMPILETIME mentioned in the issue but don't know what the Bitcode repercussions are.

I'll try to update the documentation on how to build OpenCV. I used the instructions and GitHub project mentioned https://github.com/card-io/card.io-iOS-source/blob/master/opencv_device/doc/notes.txt with similar "-fembed-bitcode" and ENABLE_BITCODE flags turned on.

bluk commented 9 years ago

Still need to fix an issue with the linker during the final Xcode Archive process for the icc app which has come up after I cleaned out a few more things, but the libCardIO.a should start having Bitcode generated segments.

bluk commented 9 years ago

Re-added some of the Linker configuration in the Xcode Project. Somehow lost those settings while I was rebasing and cleaning up some of the random commits.

billinghamj commented 9 years ago

:+1:

bluk commented 9 years ago

I rebuilt the OpenCV libraries based on the updated instructions. I rebased because the libraries are large with the Bitcode.