search

card-io / card.io-iOS-source

The open-source code for the card.io-iOS-SDK: provides fast, easy credit card scanning in mobile apps
Other
689 stars 371 forks source link

Use HTTPS submodule URL for dmz #56

Closed sharplet closed 8 years ago

sharplet commented 8 years ago

My team is unfortunately working in a network that blocks all SSH connections. We're able to use HTTPS to clone this repo, but unfortunately the dmz submodule still uses SSH, and so we're unable to clone the repo.

Would you consider accepting this change to use HTTPS for the submodule URL?

josharian commented 8 years ago

The ssh/https submodule question has folks on each side of it (cf previous discussion). However, you should be able to use git config's insteadOf. Given that, I'm going to close this for now. Thanks.

sharplet commented 8 years ago

@josharian thanks for the tip.

mnvr commented 6 years ago

I had to fork the repo just to make this change - https://github.com/coretech/card.io-iOS-source/commit/96039c2760997b64bb743248d71e8756120d7389.

I'll not reopen this issue, but perhaps @josharian you should reconsider your choice. I have nothing for-or-against in the HTTPS-vs-SSH git URL debate, but in this particular case, I am forced to use HTTPS URLs, because I cannot guarantee that all the developers in my team will necessarily have GitHub SSH set up. On the other hand, it doesn't matter (AFAIK) if they don't have HTTPS credentials set up or not, since this is a public HTTPS URL.

I understand that the HTTPS credentials would have relevance when one is trying to push back changes to the submodule, and so would impact the contributors. However, the current choice (or SSH URLs) makes it harder for the users. A casual search brings up a few others who were impacted by this: https://github.com/card-io/card.io-iOS-source/issues/84, https://github.com/card-io/card.io-iOS-source/issues/32#issuecomment-350613016.