search

card-io / card.io-iOS-source

The open-source code for the card.io-iOS-SDK: provides fast, easy credit card scanning in mobile apps
Other
689 stars 371 forks source link

Updated CardIOVideoStream's delegate to be a UIResponder to fix Xcode 8 compiler error #70

Closed reidmain closed 8 years ago

reidmain commented 8 years ago

Detailed explanation of this change is in issue https://github.com/card-io/card.io-iOS-source/issues/69

reidmain commented 8 years ago

I can't figure out how to run unit tests for the project. If I select the UnitTest scheme and try to build it I immediately get the build error CodeSign error: code signing is required for product type 'OCUnit Test Bundle' in SDK 'iOS 9.3'.

Is there something specific that needs to be configured for the unit tests?

josharian commented 8 years ago

LGTM. Leaving to someone else to merge. Don't sweat the tests. For this trivial a change in a heavily used code path, if it compiles and basic functionality works, I'd say it's good.

reidmain commented 8 years ago

Cool. I ran the example app on device and was able to recognize a credit card with no issues.

reidmain commented 8 years ago

Is there someone we can ping who can merge this PR?

josharian commented 8 years ago

@bluk @braebot

bluk commented 8 years ago

@reidmain Looks good to me. Thanks for the PR and sorry for the delay.

reidmain commented 8 years ago

@bluk no worries. Xcode 8 isn't even GM yet so I understand. If I experience any more issues while trying to integrate this into a Swift 2.3 app I'll open up some more.