search

card-io / card.io-iOS-source

The open-source code for the card.io-iOS-SDK: provides fast, easy credit card scanning in mobile apps
Other
686 stars 372 forks source link

Use HTTPS URL for submodule to allow read access for non GH users #90

Open Johennes opened 7 years ago

Johennes commented 7 years ago

This is required to be able to clone the repository and its submodules without having a GitHub account. An example use case is consuming card.io through carthage to build an iOS application within a large team of engineers where people simply cannot be required to sign up for GitHub and upload their SSH key just to build the app.

See also https://github.com/Carthage/Carthage/issues/1865

josharian commented 7 years ago

Thanks for the pull request. This has been discussed fairly extensively in the past, but my search fu is failing me. There are benefits to both ssh and https. If you need https, you can use git's insteadof support: https://stackoverflow.com/questions/1722807/git-convert-git-urls-to-http-urls.

Johennes commented 7 years ago

Thanks for the pointer. So putting this into my global .gitconfig

[url "https://github.com/card-io/card.io-dmz.git"]
    insteadOf = git@github.com:card-io/card.io-dmz.git

indeed makes card.io work with carthage. I still think it would be nice if no additional setup was required just for consuming the framework but I'm fine with this if SSH brings benefits in other use cases. :)