search

cardano-community / cardanosharp-koios

6 stars 6 forks source link

Problem deserialising tx_timestamp #15

Closed demogog closed 2 years ago

demogog commented 2 years ago

Describe the bug It seems that tx_timestamp has different formats, depending on whether one uses Testnet or Mainnet.

On Mainnet it the following: "tx_timestamp": "2021-10-10T18:42:14"

On Testnet, it is somewhat different: "tx_timestamp": 1645465882,

cardanosharp-koios library expects Mainnet format.

To Reproduce Steps to reproduce the behavior: Testnet: https://testnet.koios.rest/#post-/tx_info (just use the official examples) Mainnet: https://api.koios.rest/#post-/tx_info (just use the official examples)

Expected behavior Result should be parsed no matter what format kiosk.rest return. Probably.

Is it something that should be handled within the library or should Koios.rest fix their side?

Bets regards, Alex

rdlrt commented 2 years ago

For background, the resultant change (difference between mainnet [being pre-Vasil at Koios 1.0.1] vs other networks [using Koios 1.0.5] ) on Koios comes from the result of poll in the community discussion group (part of previous pinned messages). Post versions > 1.0.5 , it is expected that we use UNIX timestamps .

demogog commented 2 years ago

For background, the resultant change (difference between mainnet [being pre-Vasil at Koios 1.0.1] vs other networks [using Koios 1.0.5] ) on Koios comes from the result of poll in the community discussion group (part of previous pinned messages). Post versions > 1.0.5 , it is expected that we use UNIX timestamps .

Makes sense then. I'll close the bug then :)