Need to upgrade ping for new versions?

papacarp commented 1 year ago

Describe the bug Karl let me know there is a new version of cardano-cli ping that correctly identifies the new protocol versions.

To Reproduce

Steps to reproduce the behavior:
ubuntu@v2202308204272235639:~$ cncli ping --host relay0.bluecheesestakehouse.com  --port 5000
{
  "status": "ok",
  "host": "relay0.bluecheesestakehouse.com",
  "port": 5000,
  "networkProtocolVersion": 10,
  "dnsDurationMs": 1,
  "connectDurationMs": 134,
  "handshakeDurationMs": 138,
  "durationMs": 274
}ubuntu@v2202308204272235639:~$cncli --version
cncli 5.3.2
ubuntu@v2202308204272235639:~$ ./cardano-cli ping -h relay0.bluecheesestakehouse.com -p 5000 -Q -j -q
47.196.34.59:5000 Queried versions [NodeToNodeVersionV11 764824073 InitiatorAndResponder,NodeToNodeVersionV10 764824073 InitiatorAndResponder,NodeToNodeVersionV9 764824073 InitiatorAndResponder,NodeToNodeVersionV8 764824073 InitiatorAndResponder,NodeToNodeVersionV7 764824073 InitiatorAndResponder]
ubuntu@v2202308204272235639:~$ ./cardano-cli --version
cardano-cli 8.5.0.0 - linux-x86_64 - ghc-8.10
git rev a29ee68ba2c850cd50be39a3105ef191cfbc41d5

Expected behavior It should be returning version 11 of protocol

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

AndrewWestberg commented 10 months ago

This needs to be added upstream to the txpipe/pallas-network library. There needs to be support up to version 13 now.

AndrewWestberg commented 10 months ago

@papacarp Please test the latest 6.0.0-alpha2. It should support versions 11,12,13. I'm guessing 12 and 13 are after a hardfork because I can only get back 11 from the 8.7.2 node.

cardano-community / cncli

Need to upgrade ping for new versions? #41