cardano-community / guild-operators

Artifacts and scripts created by Guild operators
https://cardano-community.github.io/guild-operators
MIT License
354 stars 177 forks source link

CNODE_NAME not considered in cntools.config #412

Closed gufmar closed 4 years ago

gufmar commented 4 years ago

when setting up a cnode environment in prereqs.sh interactive mode and specifying a different than default CNODE_NAME

https://github.com/cardano-community/guild-operators/blob/master/scripts/cnode-helper-scripts/prereqs.sh#L89

this is not considered and adapted in cntools.config

https://github.com/cardano-community/guild-operators/blob/master/scripts/cnode-helper-scripts/cntools.config#L17

rdlrt commented 4 years ago

I think cntools.config is correct in this case (since $CNODE_HOME = $CNODE_PATH/$CNODE_NAME) , there are a few sed commented out which we should enable back once tested a bit thoroughly - which will help us set the appropriate updates to env files. Need to find some time to test it out

Scitz0 commented 4 years ago

Fixed by @rdlrt in #451.