cardano-community / guild-operators

Artifacts and scripts created by Guild operators
https://cardano-community.github.io/guild-operators
MIT License
354 stars 177 forks source link

Feature Request: Have gLiveView.sh display if the node is on Mainnet or Testnet #483

Closed TrevorBenson closed 4 years ago

TrevorBenson commented 4 years ago

Describe the Feature Request Currently I am manually modifying the CNODE_NAME to set Cardano Node to Testnet Node, as there is a 19 character limit. It would be nice if gLiveView either detected this or was configured to display Testnet (and/or Mainnet) to make it easier to distinguish on a NOC board or display of many nodes/relays.

Scitz0 commented 4 years ago

I assume you are referring to NODE_NAME in gLiveView and not CNODE_NAME in prereqs script. Was meant to be a string that you are free to set to whatever you like. The 19 char limit is to not mess up the overall design but nothing will break if you set a longer name.

With this said we could use the name set with prereqs.sh -t parameter as default in the script.

TrevorBenson commented 4 years ago

Yes NODE_NAME, sorry "CNODE" has started to become a force of habit quickly. While functional it still relies on the user to name the path specific to the network. I can take this issue up in my fork and find options to submit for review and potential inclusion.

rdlrt commented 4 years ago

The only problem I see with that is, we're not restricted to two testnets. I suppose using some assumptions, we can build distinction as per below:

But more importantly, the NODE_Name is not to distinguish the network but more to distinguish between the nodes (eg: some would like to name it based on geography). Thus, I feel hesistant to actually touch that field itself