cardano-community / guild-operators

Artifacts and scripts created by Guild operators
https://cardano-community.github.io/guild-operators
MIT License
354 stars 177 forks source link

Unreachable incoming peers in gLiveView.sh is dangerously misleading #894

Closed spklpool closed 3 years ago

spklpool commented 3 years ago

Describe the bug In the gLiveView peer analysis screen under "In" peers, there is often several peers indicated as Unreachable with a red number under "Total / Unreachable". This gives the operator the appearance that there is an error in their setup and could lead them to reduce the security of their pool by opening up more ports than they should to attempt to fix the "error".
UnreachablePeers

While this is acknowledged to be an expected behavior in the info screen, that acknowledgement is too subtle to a point of being potentially dangerous for the operator as stated above. The word "Unreachable" in that screen should be changed to something that looks less like an error like Undetermined and the color should be changed to Yellow or another color that reduces the appearance of an error. UnreachablePeersInfo

Scitz0 commented 3 years ago

You are not the first one to comment on this so I acknowledge that wording might be improved. Your suggestions for Undetermined and a color change sounds good to me as all connections listed in gLiveView are established connections to the node and as such ok, just not able to determine the latency.

Should be an easy fix, putting on TODO list.