cardano-community / guild-operators

Artifacts and scripts created by Guild operators
https://cardano-community.github.io/guild-operators
MIT License
354 stars 177 forks source link

CNTools - improve KES expiration #960

Closed Scitz0 closed 3 years ago

Scitz0 commented 3 years ago

Currently, CNTools rely on kes.start file to calculate the KES expiration time. gLiveView however use node metrics that are more reliable. kes.start could show wrong date if overwritten by an old backup or if KES is rotated on offline machine and this file is not moved to online machine.

I propose that we change CNTools to use node metrics if run in online mode and if metrics are available. And fallback to current method if first fail.

rdlrt commented 3 years ago

I propose that we change CNTools to use node metrics if run in online mode and if metrics are available. And fallback to current method if first fail.

Agreed, just to simplify it a small step further - instead of checking for a running node, we could simply check using startup switch vars (if started in offline mode)

rdlrt commented 3 years ago

Closed via #962