cardano-foundation / cardano-wallet

HTTP server & command-line for managing UTxOs and HD wallets in Cardano.
Apache License 2.0
764 stars 212 forks source link

[ADP-3327] Revise PKCS7 padding implementation and tests. #4528

Closed jonathanknowles closed 5 months ago

jonathanknowles commented 6 months ago

Issue

ADP-3327

Summary

This PR revises the PKCS#7 padding implementation and property tests.

In particular, we:

jonathanknowles commented 5 months ago

Merging manually, since:

  1. This PR only affects:
    • the test suite for crypto-primitives.
    • the implementation of module AES256CBC, which is not yet used anywhere outside of crypto-primitives.
  2. The above test suite has been demonstrated to pass both locally and on Buildkite (https://buildkite.com/cardano-foundation/cardano-wallet/builds/4321#018ec2c6-2568-4883-9a32-dc783c36bf9b)
  3. This branch is rebased onto the tip of master.