[ADP-3327] Small revisions to `AES256CBC`.

cardano-foundation / cardano-wallet

HTTP server & command-line for managing UTxOs and HD wallets in Cardano.

Apache License 2.0

758 stars 213 forks source link

Closed jonathanknowles closed 3 months ago

jonathanknowles commented 3 months ago

ADP-3327

This PR makes a number of small revisions to the AES256CBC module:

Use pattern guards instead of when.
Use general functions from Data.Bifunctor (in base) instead of the Either-specific combinators fromData.Either.Combinators (from the either library).

jonathanknowles commented 3 months ago

nice refactoring. In the light of using bifunctor can we remove either dependency from lib? 🤔

Good point! You're quite right -- it's possible to remove this dependency. I've done this here: 0fa5fa48533d778bfe5bc21f654baa98cac2dc8b