Move `distributeSurplus` to new `Balance.Surplus` module

cardano-foundation / cardano-wallet

HTTP server & command-line for managing UTxOs and HD wallets in Cardano.

Apache License 2.0

758 stars 213 forks source link

Move `distributeSurplus` to new `Balance.Surplus` module #4542

Closed Anviking closed 2 months ago

Anviking commented 3 months ago

[x] Move distributeSurplus to new Balance.Distribute module.

Comments

Smaller alternative to #4537, now without the Size hierarchy idea.

Issue Number

None directly.

Anviking commented 2 months ago

What do you think?

What I did like about Balance.Distribute was that it was analogous to distributeSurplus (if balance ~ surplus). From this perspective Balance.Surplus would say "balance" twice.

I am also not entirely sold on that importing this module qualified is worth it.

However, I can buy there being something to the point of having the module name a noun — so I'd be happy to settle for Balance.Surplus imported unqualified.

Does it work for you now?