Rename `s` to `changeState` within `Write.Tx.{Balance,BalanceSpec}`.

cardano-foundation / cardano-wallet

HTTP server & command-line for managing UTxOs and HD wallets in Cardano.

Apache License 2.0

757 stars 213 forks source link

Rename `s` to `changeState` within `Write.Tx.{Balance,BalanceSpec}`. #4571

Closed jonathanknowles closed 2 months ago

jonathanknowles commented 2 months ago

This PR renames variables called s to changeState in modules Write.Tx.{Balance,BalanceSpec}.

Justification

Readability and ease-of-understanding.

The balanceTx function and its cousins are quite long and have multiple concepts vying for the reader's attention. A more descriptive name is arguably helpful here.

Issue

None. Noticed while reviewing code.