[ADP-3306] Improve witness count validation in `submitTransaction`. - Githubissues

cardano-foundation / cardano-wallet

HTTP server & command-line for managing UTxOs and HD wallets in Cardano.

Apache License 2.0

757 stars 213 forks source link

[ADP-3306] Improve witness count validation in `submitTransaction`. #4594

Closed jonathanknowles closed 1 month ago

jonathanknowles commented 1 month ago

This PR follows on from #4590, and:

Extracts out witness count validation into a common function validateWitnessCounts.
Replaces fromIntegral with intCastMaybe and fromJustNote with a unique and identifiable error message.
Changes the types of fields {expected,detected}NumberOfKeyWits to Natural.
Changes the name of ErrSubmitTransactionPartiallySignedOrNoSignedTx to ErrSubmitTransactionMissingWitnesses.

Issue

ADP-3306