[ADP-3359] Simplify construction of API errors relating to recent eras.

cardano-foundation / cardano-wallet

HTTP server & command-line for managing UTxOs and HD wallets in Cardano.

Apache License 2.0

757 stars 213 forks source link

[ADP-3359] Simplify construction of API errors relating to recent eras. #4603

Closed jonathanknowles closed 1 month ago

jonathanknowles commented 1 month ago

This PR:

adds a new constant recentEras :: Set AnyRecentEra
- this constant defines the complete set of recent eras that are supported for transaction construction.
uses this constant to simplify the construction of the following API errors:
- ApiErrorNodeNotYetInRecentEra
- ApiErrorUnsupportedEra

Issue

ADP-3359

Follow-on from #4595.

jonathanknowles commented 1 month ago

👍 (I think the api is the wrong place for computations, but this is not relevant for the refactoring)

I agree with you!

Though hopefully this refactoring goes in the right direction: the definition of the set of recent eras is now in the Write layer (and no longer in the Api layer).