cardano-foundation / cardano-wallet

HTTP server & command-line for managing UTxOs and HD wallets in Cardano.
Apache License 2.0
755 stars 213 forks source link

[ADP-3368] Add benchmark format and write lib, add csv reporting to benchmarks #4621

Closed paolino closed 2 weeks ago

paolino commented 4 weeks ago

In this PR we improve the benchmarks reports to have them machine readable. The restoration benchmark is left out from this work as it's not going to appear in the CI-1 (gate-to-master) pipeline anyway as it takes 16 hours. The involved benchmarks are

  1. api
  2. latency
  3. memory
  4. db

Each of them now creates a csv artifact during its new CI-1 step.

ADP-3368

paweljakubas commented 2 weeks ago

Also, do we have commit/branch of the repo against which the benchmark was run in the final report? I would argue it would be good to have this information written down. We could store the results in a dedicated directory and be able to easily compare them. Just food for though

paolino commented 2 weeks ago

very nice refactoring and work. Left some comments. Also , this file was added intentionally lib/wallet-benchmarks/data/hoogle-pmap.txt ?

Yes, it's an input for a test