[ADP-3215] Add `TxIn` type to `Cardano.Wallet.Read.Tx`

cardano-foundation / cardano-wallet

HTTP server & command-line for managing UTxOs and HD wallets in Cardano.

Apache License 2.0

763 stars 211 forks source link

[ADP-3215] Add `TxIn` type to `Cardano.Wallet.Read.Tx` #4623

Closed HeinrichApfelmus closed 2 months ago

HeinrichApfelmus commented 3 months ago

This pull request adds a type TxIn to Cardano.Wallet.Read.Tx.TxIn.

The TxIn type is era-independent and has zero-cost conversion to the TxIn type from the Shelley ledgers.

Comments

We provide convenient pattern synonyms for TxIn and TxIx. (Unfortunately, we can't export them as bundled patterns, because GHC will not allow that for type synonyms.)

Issue Number

ADP-3215

HeinrichApfelmus commented 2 months ago

Is the point of the intermediate L.getEraInputs to explicitly document the Input types?

Yes, very much so. Paolo and I found it helpful to explicitly write down the results of applying various type families from the ledger, even though it is not strictly necessary.