search

cardano-foundation / cf-identity-wallet

Identity Wallet is an open source mobile application developed by the Cardano Foundation. It provides a digital solution for users to securely store, manage, and share their identifiers and verifiable credentials.
https://identity.cardanofoundation.org
Mozilla Public License 2.0
82 stars 11 forks source link

fix: offline mode bugs #676

Closed iFergal closed 2 weeks ago

iFergal commented 3 weeks ago

App was "online" in Redux by default, so if KERIA is down on start-up, it always thought it was online.

Now also only change online status in one place based on updates from core event bus/service.

Stop re-initialising signifyClient agent service props and don't set offline in recursive calls of agent.connect. (both of these were causing timing issues and causing it to flicker from online to offline and back continuously).

iFergal commented 2 weeks ago

@sdisalvo-crd No ticket, I was testing something last night and just fixed it.

The loading screen is not being changed by this ticket. That spinner is shown until we've at least tried to connect to the cloud and set up the DB etc

iFergal commented 2 weeks ago

And it was taken into consideration prior to the UI ticket - it was a regression AFAIK when moving the online status from appwrapper to Redux

github-actions[bot] commented 2 weeks ago

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-d5dmdtj1m.vercel.app

sdisalvo-crd commented 2 weeks ago

You're right, sorry about that, I never really paid too much attention on how long that loading page was taking before and just started looking at it now because we mentioned the app being offline by default 😅