fix(core): stop caching signer for cip-45

cardano-foundation / cf-identity-wallet

Identity Wallet is an open source mobile application developed by the Cardano Foundation. It provides a digital solution for users to securely store, manage, and share their identifiers and verifiable credentials.

https://identity.cardanofoundation.org

Mozilla Public License 2.0

91 stars 12 forks source link

fix(core): stop caching signer for cip-45 #681

Closed iFergal closed 2 months ago

iFergal commented 2 months ago

We shouldn't be caching the signer like this because if we issue a key rotation while still connected, it will try to sign with the old keys.

We could clear the cache for that identifier if a key rotation occurs but honestly it's not worth the complexity.

@jorgenavben Can you test this against ballot?

github-actions[bot] commented 2 months ago

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-qu533pz55.vercel.app