fix(ui): Animation improvements - Githubissues

cardano-foundation / cf-identity-wallet

Identity Wallet is an open source mobile application developed by the Cardano Foundation. It provides a digital solution for users to securely store, manage, and share their identifiers and verifiable credentials.

https://identity.cardanofoundation.org

Mozilla Public License 2.0

82 stars 11 forks source link

fix(ui): Animation improvements #699

Closed Sotatek-DukeVu closed 1 week ago

Sotatek-DukeVu commented 1 week ago

Description

Improve animation of side slider by using css animation instead of Ionic Animation

Checklist before requesting a review

Issue ticket number and link

[x] This PR has a valid ticket number or issue: DTIS-1293

Testing & Validation

[x] This PR has been tested/validated in IOS, Android and browser.
[x] The code has been tested locally with test coverage match expectations.
[x] Added new Unit/Component testing (if relevant).

Security

[x] No secrets are being committed (i.e. credentials, PII)
[x] This PR does not have any significant security implications

Code Review

[x] There is no unused functionality or blocks of commented out code (otherwise, please explain below)
[x] In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

[x] If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
[x] In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

https://github.com/user-attachments/assets/d19e4952-d944-40da-addb-fe5835545277

Android

Screen_recording_20240909_142446.webm

iFergal commented 1 week ago

will let @sdisalvo-crd review but I've tested this on my phone and now its super smooth everywhere, thanks!

github-actions[bot] commented 1 week ago

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-jhlixs6yv.vercel.app