cardano-foundation / developer-portal

The Cardano Developer Portal
https://developers.cardano.org
MIT License
376 stars 907 forks source link

Add `plu-ts` tag to Builder Tools? #1026

Open michele-nuzzi opened 1 year ago

michele-nuzzi commented 1 year ago

I'm opening an issue due to the specific comment (PLEASE DO NOT ADD NEW TAGS) at line 18

In the coming days, my intention is to open some pull requests to add plu-ts as developer tool and additional toolings such as cardanocli-pluts and koios-pluts.

Just like the Aiken tag It would be cool to be able to filter by a plu-ts tag

rphair commented 1 year ago

@fill-the-fill @katomm @rdlrt @os11k @gitmachtl @gufmar I think adding this tag is justified by both the 3 builder tool additions in https://github.com/cardano-foundation/developer-portal/pull/1027 and especially new page docs/smart-contracts/plu-ts.md it adds to the Overview & official smart contract platform list.

If no other objections I would approve a PR to be submitted to define the new tag. Then either the tag can be added to https://github.com/cardano-foundation/developer-portal/pull/1027 or in another PR that adds the tag itself.

@michele-nuzzi we currently have no tags with hyphens in them (it's allowed in the tag description but I don't know if it breaks the labels) so please first try a hyphen in the label in a test build locally. You might even do a test build now just so we can also discuss how to name the new tag since pluts would be confusingly similar to tag plutus.

michele-nuzzi commented 1 year ago

I was able to get the plu-ts tag working defining the tag as follows

// plu-ts
"plu-ts": {
    label: "plu-ts",
    description: "plu-ts and its development tools & libraries",
    icon: null,
    color: '#aeaeae',
},

the key has to be set using a literal string to support the hyphen.

fill-the-fill commented 1 year ago

I was able to get the plu-ts tag working defining the tag as follows

// plu-ts
"plu-ts": {
    label: "plu-ts",
    description: "plu-ts and its development tools & libraries",
    icon: null,
    color: '#aeaeae',
},

the key has to be set using a literal string to support the hyphen.

I don't mind adding this tag, would you like me to take this responsibility or add it yourself? 😊

michele-nuzzi commented 1 year ago

I was able to get the plu-ts tag working defining the tag as follows

// plu-ts
"plu-ts": {
    label: "plu-ts",
    description: "plu-ts and its development tools & libraries",
    icon: null,
    color: '#aeaeae',
},

the key has to be set using a literal string to support the hyphen.

I don't mind adding this tag, would you like me to take this responsibility or add it yourself? blush

I opened the Issue exactly due to the comment (PLEASE DO NOT ADD NEW TAGS) at line 18

If is ok with you I'm more than happy to open a pull request

fill-the-fill commented 1 year ago

Good with me, just mention that I gave my approval and this issue in the PR

rphair commented 1 year ago

OK @michele-nuzzi @fill-the-fill I had this bookmarked in my email to-do list & stuck in personal thing for 2nd of 2 days; if someone hasn't done it by tomorrow then I'll do it; just let's not all do our PRs at the same time 🤣

michele-nuzzi commented 1 year ago

@rphair @fill-the-fill opened pull request #1044

fill-the-fill commented 1 year ago

Hey @michele-nuzzi , since we've closed the #1044 , should I take care of adding the tag in a new PR?