Better handle some edge cases

carderne / signal-export

Export your Signal chats to markdown files with attachments

Other

446 stars 47 forks source link

Better handle some edge cases #1

Closed rmsds closed 3 years ago

rmsds commented 3 years ago

I've added a few data quality checks that made the script work for my case.

Also, I've only managed to get it to work using the --manual decryption mode. For the installation of sqlcipher I used https://github.com/spack/spack, I just did a PR for the package: https://github.com/spack/spack/pull/20009 If you think it's useful I can include a small section regarding how to use spack to install sqlcipher in the README.

carderne commented 3 years ago

Thanks! Yeah the code is a bit of a mess, I only look at it once every x months when I use it. This looks good and the if body is None fix will improve things for me too.
On --manual I think I'll update the README to just start there, it seems less and less likely that the 'proper' way will work as time goes on...
spack: It looks like two fewer lines to install via spack? I guess that will look less intimidating to many! Go ahead with a PR for the README, I'll merge this in the meantime.

carderne commented 3 years ago

Btw I just had to rebase because I was hasty with the merge button and it was showing the commits as authored by you, committed by me, which seems unnecessary.