cardiacsociety / web-services

MappCPD API and other services
0 stars 1 forks source link

Handlers should not report source of data #36

Closed mikedonnici closed 6 years ago

mikedonnici commented 6 years ago

In the REST(ish) server the responses include the source of the data, that is, the descriptive text that exists with the data source.

Initially, this was done to ensure safety when live testing, however, the handlers should not know anything about the source of the data as it may come from MySQL, MongoDB or some other cache in the future.

I can't think of a sensible way to provide this information back to the requester, and this ties the handlers to the datastore value as we need to express the datastore.Desc.

this is messy, and should probably juts be removed.

mikedonnici commented 6 years ago

Removed and replaced most of the message strings with "Data retrieved from ???" for now.