search

cardid / WebCard-IE

Smart Card Browser Plugin
http://plugin.cardid.org
MIT License
98 stars 35 forks source link

Resolving issue #1 #2

Closed stavros-zavrakas closed 9 years ago

stavros-zavrakas commented 9 years ago

Resolving issue #1 . There are few modifications on the X11 specific makefile and few changes on the source code. Please before accepting can you try to build on a mac and on a windows machine? I am not able to test if I broke something or not.

adricasti commented 9 years ago

Thanks a lot for this. In general, in Git is better to create a new branch (For example git checkout -b linux_build) for fixing things or adding features and then send a pull request from your feature branch so they can be merged back into the master branch. I did just that, except that I used the __linux__ preprocessor definition from SourceForge following a StackOverflow question

Could you please check to see if this newer definition works so we keep it POSIX compliant?

stavros-zavrakas commented 9 years ago

It compiles without problems using the __linux__ macro. As I told you it is the first time that I am using firebreath and trying to integrate a plugin. I am trying to integrate your plugin with google chrome but is not recognized. As I see google chrome is dropping the NPAPI. Is this the case that I am not able to load the plugin into chrome? This is the version that I have: Version 41.0.2272.76 (64-bit)

On the other hand the plugin it seems that is loaded normally on firefox but I am not able to test it using your test website: http://plugin.cardid.org.

As I see on the webcard.js script that you have and is checking if the plugin is installed there is this line var plugin = navigator.plugins["Smart Card Browser Plugin"]; but it seems that the name of the plugin that I have is this one WebCard_x86_64 and not Smart Card Browser Plugin. Also in the showDownload function there is this line if (navigator.platform == "Win32" || navigator.platform == "MacIntel") {. My platform name is Linux x86_64. Can we adjust them a bit?

If you want you can add this file into git so that I can make the modifications.

adricasti commented 9 years ago

I created a new issue for the fact that the plugin crashes in Linux. The code you mention above needs to be fixed but I guess only after we manage to get the plugin running in Linux. For the moment we can test with the local test page that you can just double click to run. Don't forget that the plugin needs to be copied in /usr/mozilla/plugins.

I also added a wiki page about building in Linux

dgrizzla commented 8 years ago

I'm getting the same error here, the browser hangs and then the plugin crash in the line reader.connect(2). I'm on linux 14.04 LTS