cardillo / joinery

Data frames for Java
https://joinery.sh
GNU General Public License v3.0
700 stars 166 forks source link

convert throws if column contains longs and then doubles #35

Closed cardillo closed 9 years ago

cardillo commented 9 years ago

the initial convert implementation only checked the first row for type conversions, therefore it was possible it would detect a column as Long numeric value but later in the frame a Double would be found causing the conversion to fail. though it is rather expensive, convert shouldn't be used all that often (the most common use will be just after reading from disk) so I think it is safe to scan the entire column to test the conversion.