search

cardinalitypuzzles / cardboard

Dashboard for managing puzzles and tracking status during a puzzle hunt
MIT License
31 stars 20 forks source link

change tags name to case insensitive class #531

Closed rawxfish closed 2 years ago

rawxfish commented 2 years ago

Hmm I'm concerned that CICharField will break tests, since it is a postgres-specific field and our tests might be using sqlite, but making PR to be sure

codecov[bot] commented 2 years ago

Codecov Report

Merging #531 (4f12f9c) into master (cacabe2) will decrease coverage by 0.14%. The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
- Coverage   87.61%   87.47%   -0.15%     
==========================================
  Files         111      113       +2     
  Lines        2576     2603      +27     
==========================================
+ Hits         2257     2277      +20     
- Misses        319      326       +7
Impacted Files Coverage Δ
puzzles/migrations/0026_dedup_puzzletag_name.py 61.11% <61.11%> (ø)
puzzles/migrations/0027_alter_puzzletag_name.py 100.00% <100.00%> (ø)
puzzles/puzzle_tag.py 95.00% <100.00%> (+0.26%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cacabe2...4f12f9c. Read the comment docs.

rawxfish commented 2 years ago

nvm, looks like django is doing something smart for postgres specific fields when sqlite is used.

rawxfish commented 2 years ago

jk, looks like the migration messes up if there is existing data that is not unique after case insensitivity. I will fix it.