search

cardinalitypuzzles / cardboard

Dashboard for managing puzzles and tracking status during a puzzle hunt
MIT License
31 stars 21 forks source link

Colorful icons #553

Closed pcvera closed 2 years ago

pcvera commented 2 years ago

Dependent on https://github.com/cardinalitypuzzles/cardboard/pull/552

I feel less certain about the colorful icons being a good idea, so this PR is separate, pending some voting about whether we like them or not. If so, should be merged after #552

Before image

After image

Dark Mode image

rgossiaux commented 2 years ago

Can you fix the merge conflict stuff now that the other PR is merged?

pcvera commented 2 years ago

done

rgossiaux commented 2 years ago

Hmm the github diff is still messed up. Anyway my vote is I think I like the colored icons more, they feel easier to scan out of the corner of your eye to me vs the block of gray. Anyone else wanna chime in?

rawxfish commented 2 years ago

+1 colored versions. My biggest concern would the sheets icon on green background for colorblind accessibility, but that icon has distinguishable non-color textures that should make it okay?

pcvera commented 2 years ago

Putting on my design hat, I think the lack of uniformity bugs me a bit.

That being said, I'm happy to be outvoted, shipping it.