search

cardinalitypuzzles / cardboard

Dashboard for managing puzzles and tracking status during a puzzle hunt
MIT License
31 stars 21 forks source link

Fix the backsolved tag/sheet renaming interaction #570

Closed rgossiaux closed 2 years ago

rgossiaux commented 2 years ago

I broke this when I changed the casing of the default tags. Making this case-insensitive.

rgossiaux commented 2 years ago

Looks like the tests are broken here because GH actions are using sqlite so I made a PR to change that over.

erwa commented 2 years ago

Looks like the tests are broken here because GH actions are using sqlite so I made a PR to change that over.

I'm guessing this is the failed run?: https://github.com/cardinalitypuzzles/cardboard/runs/4786213594?check_suite_focus=true

AssertionError: expected call not found.
Expected: delay(sheet_url='testsheet.com', name='[BACKSOLVED: ANS, ANS2] Test')
Actual: delay(sheet_url='testsheet.com', name='[SOLVED: ANS, ANS2] Test')

Do we know why it failed with sqlite but passed with Postgres? This doesn't involve the case-insensitive field so I'm surprised at the difference in behavior.

erwa commented 2 years ago

This doesn't involve the case-insensitive field so I'm surprised at the difference in behavior.

Oh nvm, I just looked at the code and you are testing case-insensitive updates. That explains why