cardoe / cargo-ebuild

cargo extension that can generate ebuilds using the in-tree eclasses
Apache License 2.0
75 stars 13 forks source link

Why `RESTRICT=mirror`? #32

Closed lo48576 closed 3 years ago

lo48576 commented 4 years ago

https://github.com/cardoe/cargo-ebuild/blob/326d33b8b3eb173783820d2d596444a1914b41d8/src/ebuild.template#L18

The RESTRICT="mirror" setting should be used if we cannot legally mirror certain files; files will still be downloaded from the original locations.

Mirrors – Gentoo Development Guide

Many projects written in Rust are OSS (as far as I know), and RESTRICT=mirror seems not necessary for such usual OSS applications, especially when we want ebuild files for them.

Why is this line included in default template?

If this exists for safety (i.e. to prevent accidentally mirroring proprietary stuff), then I want some comments in the template to indicate when this line is necessary and when unnecessary.

lo48576 commented 4 years ago

Ok, I understand this exists to prevent portage from fetching crates from mirrors while they are not deployed to mirror servers. I still want comment lines for this (because actually mirroring is not "restrict"-ed), but RESTRICT=mirror itself would be useful and should not be removed for now.

cardoe commented 4 years ago

PR is welcome if you'd like to add that boilerplate into every ebuild.

cardoe commented 3 years ago

Closing as abandoned.