search

cardoso / ReduxMovieDB

🎥 See the upcoming movies! ReSwift + RxSwift 💖 Hacktoberfest 🎃
MIT License
203 stars 35 forks source link

Make ViewStates Conform to Equatable #30

Closed fbernutz closed 4 years ago

fbernutz commented 4 years ago

This resolves issue #4.

since ReSwift 4.0.1 skipRepeats is on by default when the SubStates are Equatable. After doing this, I tested it and newState for MovieListVC and MovieDetailVC is called a few times less.

codecov-io commented 4 years ago

Codecov Report

Merging #30 into master will decrease coverage by 0.46%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   72.45%   71.99%   -0.47%     
==========================================
  Files          13       13              
  Lines         432      432              
==========================================
- Hits          313      311       -2     
- Misses        119      121       +2
Impacted Files Coverage Δ
ReduxMovieDB/ViewState/MovieDetailViewState.swift 100% <ø> (ø) :arrow_up:
ReduxMovieDB/ViewState/MovieListViewState.swift 100% <ø> (ø) :arrow_up:
ReduxMovieDB/Model/Movie+Differentiable.swift 0% <0%> (-100%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e94202...7f6c35c. Read the comment docs.