cardoso / ReduxMovieDB

🎥 See the upcoming movies! ReSwift + RxSwift 💖 Hacktoberfest 🎃
MIT License
203 stars 35 forks source link

Favorites issue #18 #34

Open ftp27 opened 4 years ago

codecov-io commented 4 years ago

Codecov Report

Merging #34 into master will increase coverage by 0.67%. The diff coverage is 73.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage    70.2%   70.88%   +0.67%     
==========================================
  Files          13       15       +2     
  Lines         443      522      +79     
==========================================
+ Hits          311      370      +59     
- Misses        132      152      +20
Impacted Files Coverage Δ
...ovieDB/Controllers/MovieDetailViewController.swift 0% <0%> (ø) :arrow_up:
ReduxMovieDB/Extensions/Boolean.swift 0% <0%> (ø)
ReduxMovieDB/ViewState/MovieDetailViewState.swift 100% <100%> (ø) :arrow_up:
...uxMovieDB/Extensions/UIImageView+MoviePoster.swift 96.72% <100%> (ø) :arrow_up:
...xMovieDB/Controllers/MovieListViewController.swift 87.03% <69.23%> (-2.55%) :arrow_down:
ReduxMovieDB/State/MainState.swift 97.05% <88.23%> (-2.95%) :arrow_down:
ReduxMovieDB/Storages/FavoritesStorage.swift 97.29% <97.29%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f57d4cb...fe60b93. Read the comment docs.

cardoso commented 4 years ago

Hi @ftp27 ! Thanks again for your contribution! I'll review as soon as possible.

ftp27 commented 4 years ago

It looks better now 🙂

cardoso commented 4 years ago

@ftp27 thank you! I'll review again as soon as possible

squash-labs[bot] commented 1 year ago

Manage this branch in Squash

Test this branch here: https://favorites-issue-18-0jcox.squash.io