Open ThaysPrado opened 4 years ago
Merging #36 into master will increase coverage by
17.43%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #36 +/- ##
===========================================
+ Coverage 69.85% 87.29% +17.43%
===========================================
Files 13 13
Lines 428 433 +5
===========================================
+ Hits 299 378 +79
+ Misses 129 55 -74
Impacted Files | Coverage Ξ | |
---|---|---|
...xMovieDB/Controllers/MovieListViewController.swift | 93.06% <100%> (+3.48%) |
:arrow_up: |
...uxMovieDB/Extensions/UIImageView+MoviePoster.swift | 96.72% <100%> (ΓΈ) |
:arrow_up: |
ReduxMovieDB/Thunks.swift | 60% <0%> (+1.81%) |
:arrow_up: |
ReduxMovieDB/API/TMDB.swift | 71.87% <0%> (+3.12%) |
:arrow_up: |
ReduxMovieDB/Controllers/SplitViewController.swift | 85.71% <0%> (+33.33%) |
:arrow_up: |
...ovieDB/Controllers/MovieDetailViewController.swift | 83.33% <0%> (+83.33%) |
:arrow_up: |
ReduxMovieDB/Model/Movie+Differentiable.swift | 100% <0%> (+100%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update e812687...3255e76. Read the comment docs.
Thanks @ThaysPrado . I'll review as soon as possible.
Both tests are failing here @ThaysPrado π€
Did you follow some guide for the UI tests? I think there should be some asserts. Maybe you can use this tutorial as a reference for the implementation: https://www.raywenderlich.com/960290-ios-unit-testing-and-ui-testing-tutorial#toc-anchor-014
This is only for a start, so even one good UI test would get this merged π
It was my first attempt with UI testing. I will see the tutorial you mentioned.
Even though it is strange, the tests worked with me, I will see this more closely. I think losing something
@ThaysPrado understood! Looking forward to the improvements. Thank you!
I started UI tests with two tests on listView and DetailsView. hope it is useful