Open christopher-fredregill opened 4 years ago
Hi @christopher-fredregill . Thanks for your contribution!
I think the UI should adhere to the current style (black/dark). See the screenshots in the README. The screen should be accessible from a button on the left side of the navigation bar of the first screen. Use the “gear” symbol from SFSymbols.
I will take a better look at your PR after these changes! Thank you again! 🙏
@cardoso is this where the gear button should go?
Merging #37 into master will decrease coverage by
4%
. The diff coverage is31.37%
.
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
- Coverage 70.2% 66.19% -4.01%
==========================================
Files 13 17 +4
Lines 443 494 +51
==========================================
+ Hits 311 327 +16
- Misses 132 167 +35
Impacted Files | Coverage Δ | |
---|---|---|
...xMovieDB/Controllers/MovieListViewController.swift | 89.58% <ø> (ø) |
:arrow_up: |
ReduxMovieDB/Views/ContributorList.swift | 0% <0%> (ø) |
|
ReduxMovieDB/Model/Contributor.swift | 0% <0%> (ø) |
|
...ovieDB/Controllers/ContributorListController.swift | 0% <0%> (ø) |
|
ReduxMovieDB/Views/ContributorProfile.swift | 0% <0%> (ø) |
|
ReduxMovieDB/AppDelegate.swift | 100% <100%> (ø) |
:arrow_up: |
ReduxMovieDB/State/MainState.swift | 100% <100%> (ø) |
:arrow_up: |
ReduxMovieDB/Thunks.swift | 64.17% <91.66%> (+5.99%) |
:arrow_up: |
... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f57d4cb...75908b8. Read the comment docs.
@christopher-fredregill yes! Sorry for the late response
@cardoso care to take a look? Not sure if this is exactly what you had in mind, but I tried to adhere to the requirements you laid out in #32 .
Also, not sure how you'd like this screen to be accessed from within the app. I temporarily added this line in
AppDelegate.swift
just to toy around with it locally:window?.rootViewController = ContributorListController(rootView: ContributorList())
Here are some sample screenshots:
Thanks!