Closed agiletalk closed 4 years ago
Thanks for your contribution @agiletalk !
Is there any way to fix this without removing the disclosure indicator? I think it's important
Merging #39 into master will decrease coverage by
0.93%
. The diff coverage is45.45%
.
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
- Coverage 70.2% 69.26% -0.94%
==========================================
Files 13 13
Lines 443 449 +6
==========================================
Hits 311 311
- Misses 132 138 +6
Impacted Files | Coverage Ξ | |
---|---|---|
...xMovieDB/Controllers/MovieListViewController.swift | 84.31% <45.45%> (-5.27%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update f57d4cb...5871466. Read the comment docs.
Thanks for your contribution @agiletalk !
Is there any way to fix this without removing the disclosure indicator? I think it's important
I fixed again without removing the disclosure indicator. And I've made some modifications to make it work properly on split view and iPad.
Thank you @agiletalk ! I'll review as soon as possible
This resolves issue #38.
Spacing on right side is a problem caused by setting a .disclosureIndicator for the accessory type of cell. So I removed it.
And Spacing on left side in landscape is a problem caused by setting insets to Safe Area. This is the default for notch design (iPhone X series)